bvaradar commented on a change in pull request #1157: [HUDI-332]Add operation
type (insert/upsert/bulkinsert/delete) to HoodieCommitMetadata
URL: https://github.com/apache/incubator-hudi/pull/1157#discussion_r362130184
##########
File path: hudi-client/src/main/java/org/apache/hudi/HoodieWriteClient.java
##########
@@ -171,7 +172,7 @@ public static SparkConf registerClasses(SparkConf conf) {
JavaRDD<HoodieRecord<T>> taggedRecords =
index.tagLocation(dedupedRecords, jsc, table);
metrics.updateIndexMetrics(LOOKUP_STR,
metrics.getDurationInMs(indexTimer == null ? 0L : indexTimer.stop()));
indexTimer = null;
- return upsertRecordsInternal(taggedRecords, commitTime, table, true);
+ return upsertRecordsInternal(taggedRecords, commitTime, table, true,
Type.UPSERT);
Review comment:
There is an enum OperationType in HoodieWriteClient. It is more fine-grained
in that it is able to distinguish between PREPPED and non-PREDDED version of
operations. Can we use that enum instead of Type. You can move it to a separate
enum class in the package org.apache.hudi.common.model and name it as
WriteOperationType
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
