bvaradar commented on a change in pull request #1157: [HUDI-332]Add operation
type (insert/upsert/bulkinsert/delete) to HoodieCommitMetadata
URL: https://github.com/apache/incubator-hudi/pull/1157#discussion_r362727612
##########
File path: hudi-spark/src/main/scala/org/apache/hudi/DataSourceOptions.scala
##########
@@ -82,10 +82,10 @@ object DataSourceWriteOptions {
* Default: upsert()
*/
val OPERATION_OPT_KEY = "hoodie.datasource.write.operation"
- val BULK_INSERT_OPERATION_OPT_VAL = "bulk_insert"
- val INSERT_OPERATION_OPT_VAL = "insert"
- val UPSERT_OPERATION_OPT_VAL = "upsert"
- val DELETE_OPERATION_OPT_VAL = "delete"
+ val BULK_INSERT_OPERATION_OPT_VAL = WriteOperationType.BULK_INSERT.toString
Review comment:
Let us not change these configuration values as it would cause backwards
compatibility issues.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
