vinothchandar commented on a change in pull request #1159: [HUDI-479] Eliminate or Minimize use of Guava if possible URL: https://github.com/apache/incubator-hudi/pull/1159#discussion_r362273016
########## File path: hudi-client/src/main/java/org/apache/hudi/io/compact/HoodieRealtimeTableCompactor.java ########## @@ -125,7 +125,7 @@ config.getCompactionReverseLogReadEnabled(), config.getMaxDFSStreamBufferSize(), config.getSpillableMapBasePath()); if (!scanner.iterator().hasNext()) { - return Lists.<WriteStatus>newArrayList(); + return new ArrayList<>(); Review comment: how about Collections.emptyList() for new list creations? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services