vinothchandar commented on a change in pull request #1159: [HUDI-479] Eliminate
or Minimize use of Guava if possible
URL: https://github.com/apache/incubator-hudi/pull/1159#discussion_r362272832
##########
File path:
hudi-client/src/main/java/org/apache/hudi/io/compact/HoodieRealtimeTableCompactor.java
##########
@@ -112,8 +112,8 @@
// loaded and load it using CompositeAvroLogReader
// Since a DeltaCommit is not defined yet, reading all the records.
revisit this soon.
String maxInstantTime = metaClient
-
.getActiveTimeline().getTimelineOfActions(Sets.newHashSet(HoodieTimeline.COMMIT_ACTION,
- HoodieTimeline.ROLLBACK_ACTION,
HoodieTimeline.DELTA_COMMIT_ACTION))
+
.getActiveTimeline().getTimelineOfActions(Stream.of(HoodieTimeline.COMMIT_ACTION,
Review comment:
Throw the set instantiation into a common `CollectionUtils#setOf()` in
hudi-common ? This way we can change the implementation underneath later on if
needed?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
