vinothchandar commented on a change in pull request #1159: [HUDI-479] Eliminate
or Minimize use of Guava if possible
URL: https://github.com/apache/incubator-hudi/pull/1159#discussion_r362271984
##########
File path:
hudi-client/src/main/java/org/apache/hudi/index/bloom/BloomIndexFileInfo.java
##########
@@ -78,23 +78,21 @@ public boolean equals(Object o) {
}
BloomIndexFileInfo that = (BloomIndexFileInfo) o;
- return Objects.equal(that.fileId, fileId) &&
Objects.equal(that.minRecordKey, minRecordKey)
- && Objects.equal(that.maxRecordKey, maxRecordKey);
+ return Objects.equals(that.fileId, fileId) &&
Objects.equals(that.minRecordKey, minRecordKey)
+ && Objects.equals(that.maxRecordKey, maxRecordKey);
}
@Override
public int hashCode() {
- return Objects.hashCode(fileId, minRecordKey, maxRecordKey);
+ return Objects.hash(fileId, minRecordKey, maxRecordKey);
}
@Override
public String toString() {
- final StringBuilder sb = new StringBuilder("BloomIndexFileInfo {");
- sb.append(" fileId=").append(fileId);
- sb.append(" minRecordKey=").append(minRecordKey);
- sb.append(" maxRecordKey=").append(maxRecordKey);
- sb.append('}');
- return sb.toString();
+ return "BloomIndexFileInfo {" + " fileId=" + fileId
Review comment:
why this change? StringBuilder reuses allocation right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
