vinothchandar commented on a change in pull request #1159: [HUDI-479] Eliminate
or Minimize use of Guava if possible
URL: https://github.com/apache/incubator-hudi/pull/1159#discussion_r362273413
##########
File path:
hudi-common/src/main/java/org/apache/hudi/common/model/HoodieKey.java
##########
@@ -58,20 +57,18 @@ public boolean equals(Object o) {
return false;
}
HoodieKey otherKey = (HoodieKey) o;
- return Objects.equal(recordKey, otherKey.recordKey) &&
Objects.equal(partitionPath, otherKey.partitionPath);
+ return Objects.equals(recordKey, otherKey.recordKey) &&
Objects.equals(partitionPath, otherKey.partitionPath);
}
@Override
public int hashCode() {
- return Objects.hashCode(recordKey, partitionPath);
+ return Objects.hash(recordKey, partitionPath);
}
@Override
public String toString() {
- final StringBuilder sb = new StringBuilder("HoodieKey {");
Review comment:
same comment on string builder.. If we print the key in fast path (for
debugging), the extra allocations would matter?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
