bvaradar commented on a change in pull request #1255: [HUDI-559] : Make sure by
default table layout version honors the configuration in hoodie.properties
URL: https://github.com/apache/incubator-hudi/pull/1255#discussion_r368362263
##########
File path:
hudi-client/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java
##########
@@ -145,7 +145,8 @@ public Boolean shouldAssumeDatePartitioning() {
}
public Integer getTimelineLayoutVersion() {
- return Integer.parseInt(props.getProperty(TIMELINE_LAYOUT_VERSION));
+ return props.containsKey(TIMELINE_LAYOUT_VERSION)
+ ? Integer.parseInt(props.getProperty(TIMELINE_LAYOUT_VERSION)) : null;
Review comment:
@vinothchandar : Unlike other configs, this is a config defined at 2 levels
- hoodie.properties and in HoodieWriteConfig. If we actually keep a non-null
value in config, the semantics is that it would override the one in
hoodie.properties. If we keep version_0 as default, it would override the
version even for new tables which has Version_1 in hoodie.properties ? Let me
know if I am missing something.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
