bvaradar commented on a change in pull request #1255: [HUDI-559] : Make sure by
default table layout version honors the configuration in hoodie.properties
URL: https://github.com/apache/incubator-hudi/pull/1255#discussion_r368398278
##########
File path:
hudi-client/src/main/java/org/apache/hudi/client/utils/ClientUtils.java
##########
@@ -37,6 +37,8 @@
public static HoodieTableMetaClient createMetaClient(JavaSparkContext jsc,
HoodieWriteConfig config,
boolean loadActiveTimelineOnLoad) {
return new HoodieTableMetaClient(jsc.hadoopConfiguration(),
config.getBasePath(), loadActiveTimelineOnLoad,
- config.getConsistencyGuardConfig(), Option.of(new
TimelineLayoutVersion(config.getTimelineLayoutVersion())));
+ config.getConsistencyGuardConfig(),
+ Option.ofNullable((config.getTimelineLayoutVersion() != null)
+ ? new TimelineLayoutVersion(config.getTimelineLayoutVersion()) :
null));
Review comment:
Yeah, this can be simplified. HoodieWriteConfig's TimelineLayoutVersion will
not be null as it has default. Will change based on that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
