vinothchandar commented on a change in pull request #1255: [HUDI-559] : Make
sure by default table layout version honors the configuration in
hoodie.properties
URL: https://github.com/apache/incubator-hudi/pull/1255#discussion_r368386515
##########
File path:
hudi-common/src/main/java/org/apache/hudi/common/table/HoodieTableMetaClient.java
##########
@@ -117,6 +117,13 @@ public HoodieTableMetaClient(Configuration conf, String
basePath, boolean loadAc
TableNotFoundException.checkTableValidity(fs, basePathDir, metaPathDir);
this.tableConfig = new HoodieTableConfig(fs, metaPath, payloadClassName);
this.tableType = tableConfig.getTableType();
+ if (layoutVersion.isPresent()) {
+ // Ensure layout version passed in config is not lower than the one seen
in hoodie.properties
+ TimelineLayoutVersion tableConfigVersion =
tableConfig.getTimelineLayoutVersion();
Review comment:
can't this be `null`? if so, would `compareTo` below be still happy?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
