vinothchandar commented on a change in pull request #1255: [HUDI-559] : Make
sure by default table layout version honors the configuration in
hoodie.properties
URL: https://github.com/apache/incubator-hudi/pull/1255#discussion_r368363395
##########
File path:
hudi-client/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java
##########
@@ -145,7 +145,8 @@ public Boolean shouldAssumeDatePartitioning() {
}
public Integer getTimelineLayoutVersion() {
- return Integer.parseInt(props.getProperty(TIMELINE_LAYOUT_VERSION));
+ return props.containsKey(TIMELINE_LAYOUT_VERSION)
+ ? Integer.parseInt(props.getProperty(TIMELINE_LAYOUT_VERSION)) : null;
Review comment:
Main issue here seems to be that, we want this config to be respected at a
write level, even when the value is not in `hoodie.properties`, for e.g support
timeline version =1 even for older tables. `hoodie.properties` is involved
here, purely because the query (any timeline reader) needs to know how to read
the timeline correct?
code style aside, I feel this is still not very clear to me.. :(
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
