bvaradar commented on a change in pull request #1396: [HUDI-687] Stop
incremental reader on RO table before a pending compaction
URL: https://github.com/apache/incubator-hudi/pull/1396#discussion_r399958899
##########
File path:
hudi-common/src/main/java/org/apache/hudi/common/table/timeline/HoodieDefaultTimeline.java
##########
@@ -136,6 +136,13 @@ public HoodieDefaultTimeline findInstantsAfter(String
instantTime, int numCommit
details);
}
+ @Override
+ public HoodieDefaultTimeline findInstantsBefore(String instantTime) {
Review comment:
Didn't realize you can have an overridden method with a return type which is
a sub-type of original return type. Learnt something new today :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
