vinothchandar commented on a change in pull request #1396: [HUDI-687] Stop
incremental reader on RO table before a pending compaction
URL: https://github.com/apache/incubator-hudi/pull/1396#discussion_r403398166
##########
File path:
hudi-client/src/test/java/org/apache/hudi/table/TestMergeOnReadTable.java
##########
@@ -1311,4 +1383,111 @@ private void assertNoWriteErrors(List<WriteStatus>
statuses) {
assertFalse("Errors found in write of " + status.getFileId(),
status.hasErrors());
}
}
+
+ private FileStatus[] insertAndGetFilePaths(List<HoodieRecord> records,
HoodieWriteClient client,
Review comment:
I am surprised by the amount of test helper code you needed to write
yourself.. Should we be using code from some existing helpers.. or should these
helpers move somewhere else, so they are beneficial over all?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
