vinothchandar commented on a change in pull request #1396: [HUDI-687] Stop
incremental reader on RO table before a pending compaction
URL: https://github.com/apache/incubator-hudi/pull/1396#discussion_r403397923
##########
File path:
hudi-client/src/test/java/org/apache/hudi/table/TestMergeOnReadTable.java
##########
@@ -186,6 +168,96 @@ public void testSimpleInsertAndUpdate() throws Exception {
}
}
+ // test incremental read does not go past compaction instant for RO views
+ // For RT views, incremental read can go past compaction
+ @Test
+ public void testIncrementalReadsWithCompaction() throws Exception {
Review comment:
Let's make it clear that this an incremental on RO.. rename to
`testIncrementalROReadsWithCOmpaction()`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
