satishkotha commented on a change in pull request #1396: [HUDI-687] Stop
incremental reader on RO table before a pending compaction
URL: https://github.com/apache/incubator-hudi/pull/1396#discussion_r403838755
##########
File path:
hudi-client/src/test/java/org/apache/hudi/table/TestMergeOnReadTable.java
##########
@@ -1311,4 +1383,111 @@ private void assertNoWriteErrors(List<WriteStatus>
statuses) {
assertFalse("Errors found in write of " + status.getFileId(),
status.hasErrors());
}
}
+
+ private FileStatus[] insertAndGetFilePaths(List<HoodieRecord> records,
HoodieWriteClient client,
Review comment:
This helper code is refactored from existing test
'TestMergeOnReadTable#testSimpleInsertAndUpdate' . I don't know this setup is
needed in other places. If you have any suggestions for new location, let me
know.
There are also no tests so far with end-to-end testing of incremental reads
on MOR tables (as far as i could tell). So I had to add some more utility test
methods for that. Please suggest if ythere is a better location for that
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
