garyli1019 commented on a change in pull request #1486: [HUDI-759] Integrate checkpoint privoder with delta streamer URL: https://github.com/apache/incubator-hudi/pull/1486#discussion_r405719163
########## File path: hudi-utilities/src/main/java/org/apache/hudi/utilities/deltastreamer/DeltaSync.java ########## @@ -153,7 +153,7 @@ private transient HoodieWriteClient writeClient; public DeltaSync(HoodieDeltaStreamer.Config cfg, SparkSession sparkSession, SchemaProvider schemaProvider, - TypedProperties props, JavaSparkContext jssc, FileSystem fs, HiveConf hiveConf, + TypedProperties props, JavaSparkContext jssc, FileSystem fs, Configuration hiveConf, Review comment: I keep `hiveConf` here for better readability. There are two other configuration `cfg` `props` here, so I believe `hiveConf` could be more clear for the user to know what this is for. WDYT? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
