vinothchandar commented on a change in pull request #1486: [HUDI-759] Integrate 
checkpoint privoder with delta streamer
URL: https://github.com/apache/incubator-hudi/pull/1486#discussion_r405967820
 
 

 ##########
 File path: 
hudi-utilities/src/main/java/org/apache/hudi/utilities/deltastreamer/HoodieDeltaStreamer.java
 ##########
 @@ -293,6 +295,12 @@ public Operation convert(String value) throws 
ParameterException {
     @Parameter(names = {"--checkpoint"}, description = "Resume Delta Streamer 
from this checkpoint.")
     public String checkpoint = null;
 
+    @Parameter(names = {"--bootstrap-from"}, description = "Initial bootstrap 
from this path")
 
 Review comment:
   this is a path where the current dataset resides? I can see that we can 
eventually use this for actually bootstrapping the dataset.. but wondering if 
for now, the CheckpointProvider just takes a property containing the base path 
for reading/.computing checkpoints? 
   
   i.e we can remove `--bootstrap-from`.. it almost sounds like we are actually 
bootstrapping the data.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to