vinothchandar commented on a change in pull request #1486: [HUDI-759] Integrate
checkpoint privoder with delta streamer
URL: https://github.com/apache/incubator-hudi/pull/1486#discussion_r405968782
##########
File path:
hudi-utilities/src/main/java/org/apache/hudi/utilities/checkpointing/InitialCheckPointProvider.java
##########
@@ -20,12 +20,23 @@
import org.apache.hudi.exception.HoodieException;
+import org.apache.hadoop.fs.FileSystem;
+import org.apache.hadoop.fs.Path;
+
/**
* Provide the initial checkpoint for delta streamer.
*/
-public interface InitialCheckPointProvider {
+public abstract class InitialCheckPointProvider {
+ protected final Path path;
+ protected final FileSystem fs;
+
+ public InitialCheckPointProvider(final Path basePath, final FileSystem
fileSystem) {
Review comment:
it may be worth turning this into `abstract void init(Path, FileSystem)`
method? that way all subclasses are forced to implement the right one..
Also can we pass the `props` or the master list of properties (like we do
for key generators) into this abstraction and let the CheckpointProvider use an
explicit property like
`hoodie.deltastreamer.checkpointprovider.kafka.connect.path` to derive the
bootstrap path
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
