garyli1019 commented on a change in pull request #1486: [HUDI-759] Integrate 
checkpoint privoder with delta streamer
URL: https://github.com/apache/incubator-hudi/pull/1486#discussion_r406552799
 
 

 ##########
 File path: 
hudi-utilities/src/main/java/org/apache/hudi/utilities/checkpointing/InitialCheckPointProvider.java
 ##########
 @@ -20,12 +20,23 @@
 
 import org.apache.hudi.exception.HoodieException;
 
+import org.apache.hadoop.fs.FileSystem;
+import org.apache.hadoop.fs.Path;
+
 /**
  * Provide the initial checkpoint for delta streamer.
  */
-public interface InitialCheckPointProvider {
+public abstract class InitialCheckPointProvider {
+  protected final Path path;
+  protected final FileSystem fs;
+
+  public InitialCheckPointProvider(final Path basePath, final FileSystem 
fileSystem) {
 
 Review comment:
   Adding `props` is a good idea. It will add more flexibility for other 
providers.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to