nsivabalan commented on code in PR #9021:
URL: https://github.com/apache/hudi/pull/9021#discussion_r1236015512
##########
hudi-client/hudi-flink-client/src/main/java/org/apache/hudi/client/HoodieFlinkTableServiceClient.java:
##########
@@ -76,18 +77,18 @@ protected HoodieFlinkTableServiceClient(HoodieEngineContext
context,
protected HoodieWriteMetadata<List<WriteStatus>> compact(String
compactionInstantTime, boolean shouldComplete) {
// only used for metadata table, the compaction happens in single thread
HoodieWriteMetadata<List<WriteStatus>> compactionMetadata =
getHoodieTable().compact(context, compactionInstantTime);
- commitCompaction(compactionInstantTime,
compactionMetadata.getCommitMetadata().get(), Option.empty());
+ commitCompaction(compactionInstantTime,
compactionMetadata.getCommitMetadata().get(), Option.empty(), Option.empty());
Review Comment:
do we have a follow up ticket to fix Flink on these gaps.
##########
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/client/SparkRDDWriteClient.java:
##########
@@ -278,14 +278,14 @@ protected JavaRDD<WriteStatus>
postWrite(HoodieWriteMetadata<JavaRDD<WriteStatus
@Override
public void commitCompaction(String compactionInstantTime,
HoodieCommitMetadata metadata, Option<Map<String, String>> extraMetadata) {
- tableServiceClient.commitCompaction(compactionInstantTime, metadata,
extraMetadata);
+ tableServiceClient.commitCompaction(compactionInstantTime, metadata,
extraMetadata, Option.empty());
}
@Override
protected void completeCompaction(HoodieCommitMetadata metadata,
HoodieTable table,
String compactionCommitTime) {
- tableServiceClient.completeCompaction(metadata, table,
compactionCommitTime);
+ tableServiceClient.completeCompaction(metadata, table,
compactionCommitTime, Option.empty());
Review Comment:
where are these used? why empty
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
