codope commented on code in PR #9021:
URL: https://github.com/apache/hudi/pull/9021#discussion_r1236519961
##########
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/client/SparkRDDWriteClient.java:
##########
@@ -278,14 +278,14 @@ protected JavaRDD<WriteStatus>
postWrite(HoodieWriteMetadata<JavaRDD<WriteStatus
@Override
public void commitCompaction(String compactionInstantTime,
HoodieCommitMetadata metadata, Option<Map<String, String>> extraMetadata) {
- tableServiceClient.commitCompaction(compactionInstantTime, metadata,
extraMetadata);
+ tableServiceClient.commitCompaction(compactionInstantTime, metadata,
extraMetadata, Option.empty());
}
@Override
protected void completeCompaction(HoodieCommitMetadata metadata,
HoodieTable table,
String compactionCommitTime) {
- tableServiceClient.completeCompaction(metadata, table,
compactionCommitTime);
+ tableServiceClient.completeCompaction(metadata, table,
compactionCommitTime, Option.empty());
Review Comment:
I am going to remove the change for compaction as key -> location mapping
doesn;t really change so no need to overload the API.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
