codope commented on code in PR #9021:
URL: https://github.com/apache/hudi/pull/9021#discussion_r1236518515
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieTableServiceClient.java:
##########
@@ -243,15 +245,17 @@ public Option<String>
scheduleCompaction(Option<Map<String, String>> extraMetada
* @param extraMetadata Extra Metadata to be stored
*/
public abstract void commitCompaction(String compactionInstantTime,
HoodieCommitMetadata metadata,
- Option<Map<String, String>>
extraMetadata);
+ Option<Map<String, String>>
extraMetadata,
+ Option<HoodieData<WriteStatus>>
writeStatuses);
/**
Review Comment:
Fair point. I just kept it for completeness. Even if we pass WriteStatus,
the `getRecordIndexUpdate` method in metadata writer will be no-op (location
change condition check should return early). I will remove the change for
compaction.
> Instead of HoodieData<WriteStatus>, can we use List<WriteStatus> ?
The metadata writer works with `HoodieData`. If we change to
List<WriteStatus> then it will trigger a collect as list. I think HoodieData
makes more sense if further computation has to be performed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
