danny0405 commented on code in PR #9021:
URL: https://github.com/apache/hudi/pull/9021#discussion_r1236192198
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieTableServiceClient.java:
##########
@@ -243,15 +245,17 @@ public Option<String>
scheduleCompaction(Option<Map<String, String>> extraMetada
* @param extraMetadata Extra Metadata to be stored
*/
public abstract void commitCompaction(String compactionInstantTime,
HoodieCommitMetadata metadata,
- Option<Map<String, String>>
extraMetadata);
+ Option<Map<String, String>>
extraMetadata,
+ Option<HoodieData<WriteStatus>>
writeStatuses);
/**
Review Comment:
And the compaction does not really change the recordKey -> location
mappings, why we need the write status list as parameter then? Even for RLI,
they should be ignored.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
