danny0405 commented on code in PR #9617:
URL: https://github.com/apache/hudi/pull/9617#discussion_r1316593194
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieClient.java:
##########
@@ -95,6 +98,8 @@ protected BaseHoodieClient(HoodieEngineContext context,
HoodieWriteConfig client
clientConfig.getHoodieClientHeartbeatIntervalInMs(),
clientConfig.getHoodieClientHeartbeatTolerableMisses());
this.metrics = new HoodieMetrics(config);
this.txnManager = new TransactionManager(config, fs);
+ TrueTimeGeneratorManager.initialize(
+ new HoodieTrueTimeConfig(new
TypedProperties(clientConfig.getProps())), hadoopConf);
Review Comment:
Kind of think we should have a tool method in `HoodieWriteConfig` named
`HoodieWriteConfig#getTimeGeneratorConfig`, and let's rename
`TrueTimeGeneratorManager` -> `TimeGeneratorManager`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
