danny0405 commented on code in PR #9617:
URL: https://github.com/apache/hudi/pull/9617#discussion_r1316598137
##########
hudi-common/src/main/java/org/apache/hudi/common/table/timeline/HoodieActiveTimeline.java:
##########
@@ -197,19 +204,28 @@ public HoodieActiveTimeline() {
private void readObject(java.io.ObjectInputStream in) throws IOException,
ClassNotFoundException {
in.defaultReadObject();
}
+
+ private boolean shouldIncludeCompletionTime(HoodieInstant instant) {
+ return instant.isCompleted()
+ && metaClient.getTimelineLayoutVersion().getVersion() ==
TimelineLayoutVersion.VERSION_2;
+ }
Review Comment:
Do we need this decision
```java
metaClient.getTimelineLayoutVersion().getVersion() ==
TimelineLayoutVersion.VERSION_2
```
The old timeline does not even have `VERSION_2` in the code path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
