danny0405 commented on code in PR #9617:
URL: https://github.com/apache/hudi/pull/9617#discussion_r1316594591
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java:
##########
@@ -200,7 +200,8 @@ public class HoodieWriteConfig extends HoodieConfig {
public static final ConfigProperty<String> TIMELINE_LAYOUT_VERSION_NUM =
ConfigProperty
.key("hoodie.timeline.layout.version")
.defaultValue(Integer.toString(TimelineLayoutVersion.CURR_VERSION))
- .withValidValues(Integer.toString(TimelineLayoutVersion.VERSION_0),
Integer.toString(TimelineLayoutVersion.VERSION_1))
+ .withValidValues(Integer.toString(TimelineLayoutVersion.VERSION_0),
+ Integer.toString(TimelineLayoutVersion.VERSION_1),
Integer.toString(TimelineLayoutVersion.VERSION_2))
Review Comment:
Do we need a VERSION_2 timeline layout? The layout does not change actually,
we only change the fine name convention of completed metadata files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
