danny0405 commented on code in PR #9617:
URL: https://github.com/apache/hudi/pull/9617#discussion_r1343359738
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/rollback/BaseRollbackActionExecutor.java:
##########
@@ -261,7 +261,10 @@ protected void finishRollback(HoodieInstant
inflightInstant, HoodieRollbackMetad
// If publish the rollback to the timeline, we finally transition the
inflight rollback
// to complete in the data table timeline
if (!skipTimelinePublish) {
-
table.getActiveTimeline().transitionRollbackInflightToComplete(inflightInstant,
+ // NOTE: no need to lock here, since !skipTimelinePublish is always
true,
+ // when skipLocking is false, txnManager above-mentioned should lock
it.
+ // when skipLocking is true, the caller should have already held the
lock.
Review Comment:
re-entrancy is good but you still need to keep track of the holdness of the
lock explicitly, we have a `LockManager` in the `TxnManager`, but the
`LockManager` is only available in the write client, and it is not designed as
a singleton now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
