danny0405 commented on code in PR #9617:
URL: https://github.com/apache/hudi/pull/9617#discussion_r1343395847
##########
hudi-common/src/main/java/org/apache/hudi/common/fs/FSUtils.java:
##########
@@ -187,7 +188,11 @@ public static String maskWithoutFileId(String instantTime,
int taskPartitionId)
}
public static String getCommitFromCommitFile(String commitFileName) {
- return commitFileName.split("\\.")[0];
+ try {
+ return HoodieInstant.extractTimestamp(commitFileName);
+ } catch (IllegalArgumentException e) {
+ return "";
Review Comment:
+1 to throw exception.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
