boneanxs commented on code in PR #9617: URL: https://github.com/apache/hudi/pull/9617#discussion_r1351725337
########## hudi-common/src/main/java/org/apache/hudi/client/transaction/lock/InProcessLockProvider.java: ########## @@ -19,16 +19,15 @@ package org.apache.hudi.client.transaction.lock; +import org.apache.hudi.common.config.HoodieCommonConfig; import org.apache.hudi.common.config.LockConfiguration; import org.apache.hudi.common.config.TypedProperties; import org.apache.hudi.common.lock.LockProvider; import org.apache.hudi.common.lock.LockState; import org.apache.hudi.common.util.ValidationUtils; -import org.apache.hudi.config.HoodieWriteConfig; import org.apache.hudi.exception.HoodieLockException; import org.apache.hadoop.conf.Configuration; -import org.jetbrains.annotations.NotNull; Review Comment: Remove import `NotNull` here since hudi-common doesn't include dep `org.jetbrains.annotations`, which could meet ClassNotFound issue when compiling. Also, I see other lockProviders also don't use this annotation, like `ZookeeperBasedLockProvider` and `HiveMetastoreBasedLockProvider`, so simply remove it here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
