danny0405 commented on code in PR #9617:
URL: https://github.com/apache/hudi/pull/9617#discussion_r1343397772


##########
hudi-common/src/main/java/org/apache/hudi/common/table/HoodieTableMetaClient.java:
##########
@@ -370,6 +377,28 @@ public synchronized HoodieActiveTimeline 
reloadActiveTimeline() {
     return activeTimeline;
   }
 
+  /**
+   * Returns next instant time in the correct format. Lock is enabled by 
default.
+   */
+  public String createNewInstantTime() {
+    return createNewInstantTime(true);
+  }
+
+  /**
+   * Returns next instant time in the correct format.
+   *
+   * @param shouldLock whether the lock should be enabled to get the instant 
time.
+   */
+  public String createNewInstantTime(boolean shouldLock) {

Review Comment:
   We've been thinking through this for a while and we want to avoid the 
dead-lock, the lock providers other than in-process is kind of not reentrant 
now.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to