leesf commented on a change in pull request #1810: URL: https://github.com/apache/hudi/pull/1810#discussion_r454969135
########## File path: hudi-spark/src/main/scala/org/apache/hudi/HoodieSparkSqlWriter.scala ########## @@ -255,6 +262,43 @@ private[hudi] object HoodieSparkSqlWriter { hiveSyncConfig } + private def metaSync(parameters: Map[String, String], + basePath: Path, + hadoopConf: Configuration): Boolean = { + val hiveSyncEnabled = parameters.get(HIVE_SYNC_ENABLED_OPT_KEY).exists(r => r.toBoolean) + var metaSyncEnabled = parameters.get(HUDI_SYNC_ENABLED_OPT_KEY).exists(r => r.toBoolean) + var syncClientToolClass = parameters.get(SYNC_CLIENT_TOOL_CLASS).get + // for backward compatibility + if (hiveSyncEnabled) { + metaSyncEnabled = true + syncClientToolClass = DEFAULT_SYNC_CLIENT_TOOL_CLASS Review comment: if user sync both hive and dla meta, the dla meta would not get synced.? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org