lw309637554 commented on a change in pull request #1810:
URL: https://github.com/apache/hudi/pull/1810#discussion_r452166076
##########
File path:
hudi-utilities/src/main/java/org/apache/hudi/utilities/deltastreamer/HoodieDeltaStreamer.java
##########
@@ -237,6 +237,9 @@ public Operation convert(String value) throws
ParameterException {
@Parameter(names = {"--enable-hive-sync"}, description = "Enable syncing
to hive")
public Boolean enableHiveSync = false;
+ @Parameter(names = {"--hoodie-sync-client-tool-class"}, description =
"Meta sync client tool, using comma to separate multi tools")
Review comment:
This place is worth discussing. For compatible, we just add a
--hoodie-sync-client-tool-class.
But i think use change --enable-hive-sync to --enable-sync reasonable , or
just add a new parameter --enable-sync and compatible the --enable-hive-sync
parameter for old users. cc @vinothchandar @leesf
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]