leesf commented on a change in pull request #1810:
URL: https://github.com/apache/hudi/pull/1810#discussion_r452827668



##########
File path: 
hudi-utilities/src/main/java/org/apache/hudi/utilities/deltastreamer/HoodieDeltaStreamer.java
##########
@@ -237,6 +237,9 @@ public Operation convert(String value) throws 
ParameterException {
     @Parameter(names = {"--enable-hive-sync"}, description = "Enable syncing 
to hive")
     public Boolean enableHiveSync = false;
 
+    @Parameter(names = {"--hoodie-sync-client-tool-class"}, description = 
"Meta sync client tool, using comma to separate multi tools")

Review comment:
       yes, `--enable-sync` is reasonable since hudi will not only supports 
sync to hive, but also other meta @garyli1019 . but as @lw309637554 pointed 
out, the compatible is a problem here, so the current solution is compromised 
solution. I am ok to rename to `--enable-sync` and document the break change 
here.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to