codope commented on code in PR #10676:
URL: https://github.com/apache/hudi/pull/10676#discussion_r1517529187
##########
hudi-common/src/main/java/org/apache/hudi/common/table/timeline/TimelineUtils.java:
##########
@@ -266,13 +266,19 @@ public static HoodieDefaultTimeline
getTimeline(HoodieTableMetaClient metaClient
* @return Hudi timeline.
*/
public static HoodieTimeline getCommitsTimelineAfter(
- HoodieTableMetaClient metaClient, String exclusiveStartInstantTime,
Option<String> lastMaxCompletionTime) {
+ HoodieTableMetaClient metaClient,
+ String exclusiveStartInstantTime,
+ Option<String> lastMaxCompletionTime,
+ boolean shouldIncludeCleanerTimeline) {
Review Comment:
We do consider dropped partitions due to replacecommit in
`TimelineUtils.getDroppedPartitions`. What was happening is that replacecommit
does not add a new filegroup to a partition when all records are deleted. Older
filegroups are not active and then subsequently cleaner thinks there are no
active filegroups in the partition and marks the partition to be deleted.
https://github.com/apache/hudi/blob/58bc859b173a3648ff5f7f2042aaadf8281cac2c/hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/clean/CleanPlanner.java#L353-L359
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
