the-other-tim-brown commented on code in PR #10676:
URL: https://github.com/apache/hudi/pull/10676#discussion_r1518082368
##########
hudi-common/src/main/java/org/apache/hudi/common/table/timeline/TimelineUtils.java:
##########
@@ -266,13 +266,19 @@ public static HoodieDefaultTimeline
getTimeline(HoodieTableMetaClient metaClient
* @return Hudi timeline.
*/
public static HoodieTimeline getCommitsTimelineAfter(
- HoodieTableMetaClient metaClient, String exclusiveStartInstantTime,
Option<String> lastMaxCompletionTime) {
+ HoodieTableMetaClient metaClient,
+ String exclusiveStartInstantTime,
+ Option<String> lastMaxCompletionTime,
+ boolean shouldIncludeCleanerTimeline) {
Review Comment:
Does it make sense to mark those partitions as deleted when the replace
commit happens though or only when the cleaner kicks in? The benefit of doing
it when the replace commit happens is that it will kick in before the files are
actually removed. I'm guessing that the lack of files was causing some issue in
a query engine. If that is the case then you will have some downtime with the
current approach of doing this after the cleaner has removed the files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
