the-other-tim-brown commented on code in PR #10676:
URL: https://github.com/apache/hudi/pull/10676#discussion_r1518112714
##########
hudi-common/src/main/java/org/apache/hudi/common/table/timeline/TimelineUtils.java:
##########
@@ -266,13 +266,19 @@ public static HoodieDefaultTimeline
getTimeline(HoodieTableMetaClient metaClient
* @return Hudi timeline.
*/
public static HoodieTimeline getCommitsTimelineAfter(
- HoodieTableMetaClient metaClient, String exclusiveStartInstantTime,
Option<String> lastMaxCompletionTime) {
+ HoodieTableMetaClient metaClient,
+ String exclusiveStartInstantTime,
+ Option<String> lastMaxCompletionTime,
+ boolean shouldIncludeCleanerTimeline) {
Review Comment:
Yes that is my concern.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
