nsivabalan commented on code in PR #10676:
URL: https://github.com/apache/hudi/pull/10676#discussion_r1518111949
##########
hudi-common/src/main/java/org/apache/hudi/common/table/timeline/TimelineUtils.java:
##########
@@ -266,13 +266,19 @@ public static HoodieDefaultTimeline
getTimeline(HoodieTableMetaClient metaClient
* @return Hudi timeline.
*/
public static HoodieTimeline getCommitsTimelineAfter(
- HoodieTableMetaClient metaClient, String exclusiveStartInstantTime,
Option<String> lastMaxCompletionTime) {
+ HoodieTableMetaClient metaClient,
+ String exclusiveStartInstantTime,
+ Option<String> lastMaxCompletionTime,
+ boolean shouldIncludeCleanerTimeline) {
Review Comment:
its not the lack of files. but cleaner deleted the physical partition dir,
but we missed to sync to metastore and hence. but I see your point too.
your suggestion is to reverse the ordering. if it goes into replace commit,
first we will sync to metastore to drop the partition and later lazily cleaner
will take care of deleting the dir physically.
But w/ current approach, just after cleaner runs(after this fix), and before
we run meta sync, if someone is querying, we might run into issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
