crrow commented on code in PR #92:
URL: https://github.com/apache/hudi-rs/pull/92#discussion_r1694049605
##########
.github/workflows/ci.yml:
##########
@@ -53,14 +53,15 @@ jobs:
strategy:
fail-fast: false
matrix:
- # TODO: add windows which does not support container
- os: [ ubuntu-22.04 ]
+ os:
+ - ubuntu-22.04
+ - windows-2022
runs-on: ${{ matrix.os }}
- container:
- image: xd009642/tarpaulin:0.30.0
- options: --security-opt seccomp=unconfined
steps:
- uses: actions/checkout@v4
+ - uses: cargo-bins/cargo-binstall@main
+ - name: Install tarpaulin
+ run: cargo binstall -y cargo-tarpaulin
Review Comment:
What's your thought on separator and test case? Some test failed because of
rust's automatic normalize, and URL parse failed since some test cases are
Linux path, and it cannot be parsed on Windows.
By the way, I think some test cases can be rewritten with
https://crates.io/crates/test-case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
