xushiyan commented on code in PR #92:
URL: https://github.com/apache/hudi-rs/pull/92#discussion_r1695691238
##########
.github/workflows/ci.yml:
##########
@@ -53,14 +53,15 @@ jobs:
strategy:
fail-fast: false
matrix:
- # TODO: add windows which does not support container
- os: [ ubuntu-22.04 ]
+ os:
+ - ubuntu-22.04
+ - windows-2022
runs-on: ${{ matrix.os }}
- container:
- image: xd009642/tarpaulin:0.30.0
- options: --security-opt seccomp=unconfined
steps:
- uses: actions/checkout@v4
+ - uses: cargo-bins/cargo-binstall@main
+ - name: Install tarpaulin
+ run: cargo binstall -y cargo-tarpaulin
Review Comment:
> @xushiyan Do we have to handle this
[case?](https://github.com/apache/hudi-rs/blob/main/crates/core/src/storage/utils.rs#L94)
, its tricky for windows
@crrow that path is a unix path which should not be applicable to windows
os. Can we split that case to test case which does not run on windows, and also
add a windows specific test case with an example windows path ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
