xushiyan commented on code in PR #92:
URL: https://github.com/apache/hudi-rs/pull/92#discussion_r1694051699
##########
.github/workflows/ci.yml:
##########
@@ -53,14 +53,15 @@ jobs:
strategy:
fail-fast: false
matrix:
- # TODO: add windows which does not support container
- os: [ ubuntu-22.04 ]
+ os:
+ - ubuntu-22.04
+ - windows-2022
runs-on: ${{ matrix.os }}
- container:
- image: xd009642/tarpaulin:0.30.0
- options: --security-opt seccomp=unconfined
steps:
- uses: actions/checkout@v4
+ - uses: cargo-bins/cargo-binstall@main
+ - name: Install tarpaulin
+ run: cargo binstall -y cargo-tarpaulin
Review Comment:
@crrow absolutely! we should separate test code fix from CI setup change.
Feel free to create another PR for the test fix wrt url parsing. You may also
make the code change here so we know the test fix can pass with the CI, then
separate it out. It's up to you.
I've thought about using some test helper lib but not sure if
https://github.com/frondeus/test-case is the best candidate. there are many
crates maintained by community like https://github.com/la10736/rstest seems
more popular with more recent releases. I'll create an issue about this for
future refactoring work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
