crrow commented on code in PR #92:
URL: https://github.com/apache/hudi-rs/pull/92#discussion_r1698417775
##########
.github/workflows/ci.yml:
##########
@@ -53,14 +53,15 @@ jobs:
strategy:
fail-fast: false
matrix:
- # TODO: add windows which does not support container
- os: [ ubuntu-22.04 ]
+ os:
+ - ubuntu-22.04
+ - windows-2022
runs-on: ${{ matrix.os }}
- container:
- image: xd009642/tarpaulin:0.30.0
- options: --security-opt seccomp=unconfined
steps:
- uses: actions/checkout@v4
+ - uses: cargo-bins/cargo-binstall@main
+ - name: Install tarpaulin
+ run: cargo binstall -y cargo-tarpaulin
Review Comment:
Oh...I found that its still tricky, like "C:\\foo", `url::parse` will
success, it thoughts 'c' is the schema, rather than a filepath; for "\\foo",
`url::parse` and `url::from_filepath` will all fail; We can handle both cases
by adding additional check like if current os is windows and the given str has
":\\".
Can we be stricter about what qualifies as a 'valid URL'? Like a valid URL
must have a schema.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
