yihua commented on code in PR #11943:
URL: https://github.com/apache/hudi/pull/11943#discussion_r1811517656
##########
hudi-common/src/main/java/org/apache/hudi/common/table/HoodieTableConfig.java:
##########
@@ -185,43 +195,26 @@ public class HoodieTableConfig extends HoodieConfig {
.key("hoodie.timeline.layout.version")
.noDefaultValue()
.withDocumentation("Version of timeline used, by the table.");
-
- //TODO: why is this the default? not OVERWRITE_WITH_LATEST?
- public static final ConfigProperty<String> RECORD_MERGE_MODE = ConfigProperty
+
+ public static final ConfigProperty<RecordMergeMode> RECORD_MERGE_MODE =
ConfigProperty
.key("hoodie.record.merge.mode")
- .defaultValue(RecordMergeMode.EVENT_TIME_ORDERING.name())
+ .defaultValue(RecordMergeMode.EVENT_TIME_ORDERING)
.sinceVersion("1.0.0")
.withDocumentation(RecordMergeMode.class);
public static final ConfigProperty<String> PAYLOAD_CLASS_NAME =
ConfigProperty
.key("hoodie.compaction.payload.class")
- .defaultValue(DefaultHoodieRecordPayload.class.getName())
+ .noDefaultValue()
Review Comment:
Both `HoodieTableConfig` and `HoodiePayloadConfig` classes define
`PAYLOAD_CLASS_NAME`. Should we just keep one of them?
`HoodiePayloadConfig.PAYLOAD_CLASS_NAME` still has default value.
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java:
##########
@@ -1747,7 +1744,7 @@ public int getAsyncClusterMaxCommits() {
}
public String getPayloadClass() {
- return getString(HoodiePayloadConfig.PAYLOAD_CLASS_NAME);
+ return RecordPayloadType.getPayloadClassName(this);
Review Comment:
I looked at the usage of `HoodiePayloadConfig.PAYLOAD_CLASS_NAME` and the
logic looks to be working.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
