yihua commented on code in PR #11943:
URL: https://github.com/apache/hudi/pull/11943#discussion_r1811552659
##########
hudi-common/src/main/java/org/apache/hudi/common/engine/HoodieReaderContext.java:
##########
@@ -89,11 +91,11 @@ public void setLatestCommitTime(String latestCommitTime) {
this.latestCommitTime = latestCommitTime;
}
- public HoodieRecordMerger getRecordMerger() {
+ public Option<HoodieRecordMerger> getRecordMerger() {
return recordMerger;
}
- public void setRecordMerger(HoodieRecordMerger recordMerger) {
+ public void setRecordMerger(Option<HoodieRecordMerger> recordMerger) {
this.recordMerger = recordMerger;
}
Review Comment:
Is it because the passed-in `recordMerger` can be `Option.empty()`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
