danny0405 commented on code in PR #12608:
URL: https://github.com/apache/hudi/pull/12608#discussion_r1909701282
##########
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/client/utils/SparkMetadataWriterUtils.java:
##########
@@ -190,9 +190,16 @@ private static List<HoodieRecord>
getUnmergedLogFileRecords(List<String> logFile
.withLatestInstantTime(metaClient.getActiveTimeline().getCommitsTimeline().lastInstant().get().requestedTime())
.withReaderSchema(readerSchema)
.withTableMetaClient(metaClient)
- .withLogRecordScannerCallback(records::add)
.build();
- scanner.scan(false);
+ Iterator<HoodieRecord<?>> recordIterator = scanner.iterator();
Review Comment:
Is it possible we return an iterator too for method
`getUnmergedLogFileRecords` to the list add/get can be simplified.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
