danny0405 commented on code in PR #12608:
URL: https://github.com/apache/hudi/pull/12608#discussion_r1909703029
##########
hudi-common/src/main/java/org/apache/hudi/common/table/log/AbstractHoodieLogRecordScanner.java:
##########
@@ -617,6 +617,8 @@ &&
compareTimestamps(logBlock.getLogBlockHeader().get(INSTANT_TIME), GREATER_THA
/**
* Iterate over the GenericRecord in the block, read the hoodie key and
partition path and call subclass processors to
* handle it.
+ * TODO:
+ * 1. what is the purpose of this method? should the HoodieRecord be added
to a queue and consumed by an iterator?
*/
private void processDataBlock(HoodieDataBlock dataBlock, Option<KeySpec>
keySpecOpt) throws Exception {
Review Comment:
This should be the main entry for handling the log blocks, each kind of log
block would trigger invocation of specific row-level handling methods.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
