danny0405 commented on code in PR #12608:
URL: https://github.com/apache/hudi/pull/12608#discussion_r1909706326
##########
hudi-common/src/main/java/org/apache/hudi/common/table/log/HoodieUnMergedLogRecordScanner.java:
##########
@@ -185,16 +213,6 @@ public Builder withInstantRange(Option<InstantRange>
instantRange) {
return this;
}
- public Builder withLogRecordScannerCallback(LogRecordScannerCallback
callback) {
- this.callback = callback;
- return this;
- }
-
- public Builder withRecordDeletionCallback(RecordDeletionCallback
recordDeletionCallback) {
- this.recordDeletionCallback = recordDeletionCallback;
Review Comment:
The `recordDeletionCallback` is only consumer for deleted reords from the
delete avro block, we may need another iterator impl specifically for it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
