danny0405 commented on code in PR #12600:
URL: https://github.com/apache/hudi/pull/12600#discussion_r1906452420
##########
hudi-common/src/main/java/org/apache/hudi/common/table/HoodieTableConfig.java:
##########
@@ -198,7 +198,8 @@ public class HoodieTableConfig extends HoodieConfig {
public static final ConfigProperty<RecordMergeMode> RECORD_MERGE_MODE =
ConfigProperty
.key("hoodie.record.merge.mode")
- .defaultValue(RecordMergeMode.EVENT_TIME_ORDERING)
+ .defaultValue((RecordMergeMode) null,
+ "COMMIT_TIME_ORDERING if precombine is not set; EVENT_TIME_ORDERING
if precombine is set")
Review Comment:
Can we simplify the logic in `HoodieTableConfig.inferCorrectMergingBehavior`
? It looks way too complicated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
