yihua commented on code in PR #12826:
URL: https://github.com/apache/hudi/pull/12826#discussion_r1974136068
##########
hudi-cli/src/main/java/org/apache/hudi/cli/commands/CleansCommand.java:
##########
@@ -77,8 +75,7 @@ public String showCleans(
List<HoodieInstant> cleans =
timeline.getReverseOrderedInstants().collect(Collectors.toList());
List<Comparable[]> rows = new ArrayList<>();
for (HoodieInstant clean : cleans) {
- HoodieCleanMetadata cleanMetadata =
-
TimelineMetadataUtils.deserializeHoodieCleanMetadata(timeline.getInstantDetails(clean).get());
+ HoodieCleanMetadata cleanMetadata =
timeline.loadHoodieCleanMetadata(clean);
Review Comment:
Could we directly use `timeline.loadInstantContent` as the `HoodieInstant`
already contains all the infomation of the metadata type and instant
information, so we can reduce the number of exposed APIs?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
