yihua commented on code in PR #12826:
URL: https://github.com/apache/hudi/pull/12826#discussion_r1974202256
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/clean/CleanPlanner.java:
##########
@@ -244,13 +242,11 @@ private boolean isAnySavepointDeleted(HoodieCleanMetadata
cleanMetadata) {
private Stream<String> getPartitionsForInstants(HoodieInstant instant) {
try {
if (HoodieTimeline.REPLACE_COMMIT_ACTION.equals(instant.getAction())) {
- HoodieReplaceCommitMetadata replaceCommitMetadata =
HoodieReplaceCommitMetadata.fromBytes(
- hoodieTable.getActiveTimeline().getInstantDetails(instant).get(),
HoodieReplaceCommitMetadata.class);
+ TimelineLayout layout =
TimelineLayout.fromVersion(hoodieTable.getMetaClient().getTimelineLayoutVersion());
Review Comment:
seems redundant
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/upgrade/EightToSevenDowngradeHandler.java:
##########
@@ -305,9 +305,9 @@ static boolean
rewriteTimelineV2InstantFileToV1Format(HoodieInstant instant, Hoo
|| ((instant.getAction().equals(REPLACE_COMMIT_ACTION) ||
instant.getAction().equals(CLUSTERING_ACTION)) && instant.isCompleted())) {
Option<byte[]> data;
if (instant.getAction().equals(REPLACE_COMMIT_ACTION) ||
instant.getAction().equals(CLUSTERING_ACTION)) {
- data =
commitMetadataSerDeV1.serialize(HoodieReplaceCommitMetadata.fromBytes(metaClient.getActiveTimeline().getInstantDetails(instant).get(),
HoodieReplaceCommitMetadata.class));
+ data =
commitMetadataSerDeV1.serialize(metaClient.getActiveTimeline().loadInstantContent(instant,
HoodieReplaceCommitMetadata.class));
Review Comment:
Looks like this is a bug fix. Do we have a test covering this?
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/upgrade/EightToSevenDowngradeHandler.java:
##########
@@ -305,9 +305,9 @@ static boolean
rewriteTimelineV2InstantFileToV1Format(HoodieInstant instant, Hoo
|| ((instant.getAction().equals(REPLACE_COMMIT_ACTION) ||
instant.getAction().equals(CLUSTERING_ACTION)) && instant.isCompleted())) {
Option<byte[]> data;
if (instant.getAction().equals(REPLACE_COMMIT_ACTION) ||
instant.getAction().equals(CLUSTERING_ACTION)) {
- data =
commitMetadataSerDeV1.serialize(HoodieReplaceCommitMetadata.fromBytes(metaClient.getActiveTimeline().getInstantDetails(instant).get(),
HoodieReplaceCommitMetadata.class));
+ data =
commitMetadataSerDeV1.serialize(metaClient.getActiveTimeline().loadInstantContent(instant,
HoodieReplaceCommitMetadata.class));
} else {
- data =
commitMetadataSerDeV1.serialize(commitMetadataSerDeV2.deserialize(instant,
metaClient.getActiveTimeline().getInstantDetails(instant).get(),
HoodieCommitMetadata.class));
+ data =
commitMetadataSerDeV1.serialize(metaClient.getActiveTimeline().loadInstantContent(instant,
HoodieCommitMetadata.class));
Review Comment:
nit: see if this if-else branch can be simplified.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
