yihua commented on code in PR #12826:
URL: https://github.com/apache/hudi/pull/12826#discussion_r1974217541
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/upgrade/EightToSevenDowngradeHandler.java:
##########
@@ -305,9 +305,9 @@ static boolean
rewriteTimelineV2InstantFileToV1Format(HoodieInstant instant, Hoo
|| ((instant.getAction().equals(REPLACE_COMMIT_ACTION) ||
instant.getAction().equals(CLUSTERING_ACTION)) && instant.isCompleted())) {
Option<byte[]> data;
if (instant.getAction().equals(REPLACE_COMMIT_ACTION) ||
instant.getAction().equals(CLUSTERING_ACTION)) {
- data =
commitMetadataSerDeV1.serialize(HoodieReplaceCommitMetadata.fromBytes(metaClient.getActiveTimeline().getInstantDetails(instant).get(),
HoodieReplaceCommitMetadata.class));
+ data =
commitMetadataSerDeV1.serialize(metaClient.getActiveTimeline().loadInstantContent(instant,
HoodieReplaceCommitMetadata.class));
Review Comment:
I assume `metaClient.getActiveTimeline()` is V2 here.
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/upgrade/SevenToEightUpgradeHandler.java:
##########
@@ -289,7 +289,7 @@ static boolean
rewriteTimelineV1InstantFileToV2Format(HoodieInstant instant, Hoo
boolean success = true;
if (instant.getAction().equals(COMMIT_ACTION) ||
instant.getAction().equals(DELTA_COMMIT_ACTION) ||
(instant.getAction().equals(REPLACE_COMMIT_ACTION) && instant.isCompleted())) {
Class<? extends HoodieCommitMetadata> clazz =
instant.getAction().equals(REPLACE_COMMIT_ACTION) ?
HoodieReplaceCommitMetadata.class : HoodieCommitMetadata.class;
- HoodieCommitMetadata commitMetadata =
commitMetadataSerDeV1.deserialize(instant,
metaClient.getActiveTimeline().getInstantDetails(instant).get(), clazz);
+ HoodieCommitMetadata commitMetadata =
metaClient.getActiveTimeline().loadInstantContent(instant,clazz);
Review Comment:
To check: `metaClient.getActiveTimeline()` is V1?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
