yihua commented on code in PR #12826:
URL: https://github.com/apache/hudi/pull/12826#discussion_r1974180288
##########
hudi-cli/src/main/java/org/apache/hudi/cli/commands/RollbacksCommand.java:
##########
@@ -97,8 +95,8 @@ public String showRollback(
throws IOException {
HoodieActiveTimeline activeTimeline =
HoodieCLI.getTableMetaClient().getActiveTimeline();
final List<Comparable[]> rows = new ArrayList<>();
- HoodieRollbackMetadata metadata =
TimelineMetadataUtils.deserializeAvroMetadata(
-
activeTimeline.getInstantDetails(HoodieCLI.getTableMetaClient().createNewInstant(State.COMPLETED,
ROLLBACK_ACTION, rollbackInstant)).get(),
+ HoodieRollbackMetadata metadata = activeTimeline.loadInstantContent(
Review Comment:
nit: remove extra space
##########
hudi-cli/src/main/java/org/apache/hudi/cli/commands/StatsCommand.java:
##########
@@ -77,8 +77,7 @@ public String writeAmplificationStats(
TimelineLayout layout =
TimelineLayout.fromVersion(timeline.getTimelineLayoutVersion());
for (HoodieInstant instantTime : timeline.getInstants()) {
String waf = "0";
- HoodieCommitMetadata commit =
layout.getCommitMetadataSerDe().deserialize(instantTime,
activeTimeline.getInstantDetails(instantTime).get(),
- HoodieCommitMetadata.class);
+ HoodieCommitMetadata commit =
activeTimeline.loadInstantContent(instantTime, HoodieCommitMetadata.class);
Review Comment:
```suggestion
HoodieCommitMetadata commit =
activeTimeline.loadInstantContent(instant, HoodieCommitMetadata.class);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
